-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitattributes #1449
Update .gitattributes #1449
Conversation
.gitattributes
Outdated
nvm-exec eol=lf | ||
Makefile eol=lf | ||
bash_completion eol=lf | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just change this to * eol=lf
? There's no reason to ever have a CR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmmm ... if you are sure that we'll have only text files inside the repo, I think - yes, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean only test files?
There's no reason for any file anywhere to ever have a CRLF, is what I'm saying, and if there's an explicit exception because we need to test CRLFs, we'd add it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljharb sorry, typo - text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't imagine why we'd have anything else, but we can deal with that as it comes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, updated already
74b9dc8
to
6830dd9
Compare
No description provided.