Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes #1449

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Update .gitattributes #1449

merged 1 commit into from
Mar 23, 2017

Conversation

PeterDaveHello
Copy link
Collaborator

No description provided.

.gitattributes Outdated
nvm-exec eol=lf
Makefile eol=lf
bash_completion eol=lf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just change this to * eol=lf? There's no reason to ever have a CR.

Copy link
Collaborator Author

@PeterDaveHello PeterDaveHello Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm ... if you are sure that we'll have only text files inside the repo, I think - yes, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean only test files?

There's no reason for any file anywhere to ever have a CRLF, is what I'm saying, and if there's an explicit exception because we need to test CRLFs, we'd add it here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb sorry, typo - text

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't imagine why we'd have anything else, but we can deal with that as it comes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, updated already

@ljharb ljharb merged commit 4c97828 into nvm-sh:master Mar 23, 2017
@PeterDaveHello PeterDaveHello deleted the gitattributes branch March 23, 2017 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants