[Tests] Improve npm dependencies installation in travis ci #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
changed the title
ljharb
requested changes
Mar 23, 2017
.travis.yml
Outdated
| @@ -22,16 +22,14 @@ before_install: | |||
| - curl --version | |||
| - wget --version | |||
| - if [ -n "${SHELLCHECK-}" ]; then cabal update && cabal install transformers-0.4.3.0 ShellCheck && shellcheck --version ; fi | |||
| - if [ -n "${DOCTOCCHECK-}" ]; then nvm install node && npm install -g doctoc && type doctoc ; fi | |||
| - nvm install node && npm install && ls node_modules/urchin/urchin && ls node_modules/doctoc/doctoc.js | |||
There was a problem hiding this comment.
I think instead of the ls commands we could use npm ls urchin doctoc here?
.travis.yml
Outdated
| - '[ -z "$WITHOUT_CURL" ] || sudo apt-get remove curl -y' | ||
| script: | ||
| - if [ -n "${DOCTOCCHECK-}" ]; then cp README.markdown README.markdown.orig && npm run doctoc && diff -q README.markdown README.markdown.orig ; fi | ||
| - if [ -n "${SHELLCHECK-}" ]; then shellcheck -s bash nvm.sh && shellcheck -s sh nvm.sh && shellcheck -s dash nvm.sh && shellcheck -s ksh nvm.sh ; fi | ||
| - if [ -n "${SHELLCHECK-}" ]; then shellcheck -s bash install.sh bash_completion nvm-exec ; fi | ||
| - if [ -n "${SHELL-}" ] && [ -n "${TEST_SUITE}" ]; then make TEST_SUITE=$TEST_SUITE URCHIN=/tmp/urchin/package/urchin test-$SHELL ; fi | ||
| - if [ -n "${SHELL-}" ] && [ -n "${TEST_SUITE}" ]; then make TEST_SUITE=$TEST_SUITE URCHIN="${TRAVIS_BUILD_DIR}/node_modules/urchin/urchin" test-$SHELL ; fi |
There was a problem hiding this comment.
this should use $(npm bin)/urchin rather than harcoding node_modules as well as the "bin" path.
PeterDaveHello
force-pushed
the
travis-ci-npm-dep
branch
from
d13fea0
to
caa35b1
Compare
ljharb
reviewed
Mar 24, 2017
.travis.yml
Outdated
| - '[ -z "$WITHOUT_CURL" ] || sudo apt-get remove curl -y' | ||
| script: | ||
| - if [ -n "${DOCTOCCHECK-}" ]; then cp README.markdown README.markdown.orig && npm run doctoc && diff -q README.markdown README.markdown.orig ; fi | ||
| - if [ -n "${SHELLCHECK-}" ]; then shellcheck -s bash nvm.sh && shellcheck -s sh nvm.sh && shellcheck -s dash nvm.sh && shellcheck -s ksh nvm.sh ; fi | ||
| - if [ -n "${SHELLCHECK-}" ]; then shellcheck -s bash install.sh bash_completion nvm-exec ; fi | ||
| - if [ -n "${SHELL-}" ] && [ -n "${TEST_SUITE}" ]; then make TEST_SUITE=$TEST_SUITE URCHIN=/tmp/urchin/package/urchin test-$SHELL ; fi | ||
| - if [ -n "${SHELL-}" ] && [ -n "${TEST_SUITE}" ]; then make TEST_SUITE=$TEST_SUITE URCHIN="${TRAVIS_BUILD_DIR}/$(npm bin)/urchin/urchin" test-$SHELL ; fi |
There was a problem hiding this comment.
I don't think the Travis build dir is needed at all; npm bin is an absolute path.
There was a problem hiding this comment.
Also, you now don't need the double urchin. Just $(npm bin)/urchin alone should be sufficient.
There was a problem hiding this comment.
oops, sorry for my careless, just fixed it
PeterDaveHello
force-pushed
the
travis-ci-npm-dep
branch
from
caa35b1
to
e41197e
Compare
ljharb
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.