Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'or Linux' to **Note:** #1566

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Added 'or Linux' to **Note:** #1566

merged 1 commit into from
Jul 11, 2017

Conversation

itsmikeferrari
Copy link
Contributor

@itsmikeferrari itsmikeferrari commented Jun 26, 2017

Added this for Linux users who may skip over the bit of information because it looks like it pertained only to OS X. Most developers will know about reopening the terminal window, but noobs don't. ;-)

Fixes #1565

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good as-is, however - it'd be nice to tweak it further, since the bash_profile comments are specific to OS X.

Maybe adding a separate note higher up that duplicates the "restart your terminal" instructions?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

If you don't get to the one comment before I do, I'll fix it as part of merging. Appreciate the help!

README.md Outdated
```sh
command -v nvm
```
simply close your current terminal, open a new terminal and try verifying again.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs an oxford comma after "terminal" :-)

@ljharb ljharb merged commit 6921adb into nvm-sh:master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants