[New] Print $TERM_PROGRAM in nvm debug if it exists #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jul 13, 2017
nvm.sh
Outdated
| @@ -2357,6 +2357,9 @@ nvm() { | |||
| setopt shwordsplit | |||
| fi | |||
| nvm_err "nvm --version: v$(nvm --version)" | |||
| if [ -n "$TERM_PROGRAM" ]; then | |||
There was a problem hiding this comment.
this needs ${TERM_PROGRAM-} to avoid errors if -x is set.
There was a problem hiding this comment.
Will there be a problem even in if condition? I thought i'll be caught?
There was a problem hiding this comment.
the one inside the condition is safe; i'm pretty sure the one in the condition itself is not
There was a problem hiding this comment.
hmmm ... didn't know that before, could learn something here, I'll figure it out :) Fixed now.
ljharb
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it exists anywhere else but macOS, may help debug in situation like #1553 and #1577
e.g.
iTerm.appHyperApple_Terminal