Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copyright] update to 2018 #1713

Merged
merged 1 commit into from
Feb 9, 2018
Merged

[copyright] update to 2018 #1713

merged 1 commit into from
Feb 9, 2018

Conversation

akkumar
Copy link
Contributor

@akkumar akkumar commented Jan 25, 2018

Update the year to 2018

LICENSE.md Outdated
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2010-2017 Tim Caswell
Copyright (c) 2010-2018 Tim Caswell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but actually this doesn't need to be updated every year in order to cover the legal angle. Let's just revert it back to 2010, so we never need these PRs again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb - checked in. let me know changes if any

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you can rebase this down to one commit, great, otherwise I'll do it prior to merging.

@akkumar
Copy link
Contributor Author

akkumar commented Jan 26, 2018

@ljharb - (force) checked in. fyi

@akkumar
Copy link
Contributor Author

akkumar commented Jan 26, 2018

@ljharb - the build seems to have failed. wonder if that is a momentary ci flakiness. can you help kick off a new build though to see if this failure is momentary ?

@ljharb
Copy link
Member

ljharb commented Jan 26, 2018

Doesn't seem to be a fluke; it probably affects master too. I'll try to fix it there.

@akkumar
Copy link
Contributor Author

akkumar commented Feb 6, 2018

@ljharb - curious if the issue has been fixed in master ? Any tracking pr / issue regarding the same ?

@ljharb ljharb merged commit f5b5f2d into nvm-sh:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants