Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix required java version #341

Merged
merged 5 commits into from
Dec 16, 2023

Conversation

ariyonaty
Copy link
Contributor

Fixes

Small change updating documentation specifying Java 17 as the primary version from the original range of versions 8 to 14.
Pulled the latest tool today and was met with the following despite having Java 11 installed:

$ npm-groovy-lint
Java jre or jdk 17 is required
Installing Java jre 17 in <path>

Hopefully this helps provide clarification to others as well.

@nvuillam
Copy link
Owner

nvuillam commented Dec 12, 2023

Thanks @ariyonaty :)
Plz can you run npm run build ?

@ariyonaty
Copy link
Contributor Author

Alrighty.. clearly I'm doing something wrong. I'll stop kicking off checks until I get a follow up.
Unfortunately not familiar with node/npm, so this is a bit out of my element.

Tried:

  • Running npm run build standalone. Doesn't generate any diff.
  • Running npm install, then npm link, followed by npm run build. Still no diff (aside from package-lock.json)
  • In an attempt to mirror pipeline, npm run dev:pre-commit generates a diff in the form of updated lib/java/CodeNarcServer.jar, however latest build still shows failure.

Suggestions?

@nvuillam
Copy link
Owner

@stevenh can help us I think :)

@stevenh
Copy link
Collaborator

stevenh commented Dec 16, 2023

The change is in the generation of the server jar, have you followed the guide I created for this problem?

I would put money on you having a different node version, which uses a different version built in compression module.

Copy link
Owner

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated your branch to make it pass, thanks for the PR :)

@nvuillam nvuillam merged commit 716e4bf into nvuillam:main Dec 16, 2023
6 checks passed
@ariyonaty ariyonaty deleted the docs/fix-java-version branch December 17, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants