Profile allocations in benchmarks #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvzqz
force-pushed
the
feat/alloc
branch
5 times, most recently
from
0ecb3df
to
153d42e
Compare
This adds `AllocProfiler`, an allocator implementation that tracks the number of allocations and bytes allocated during benchmarks. It can wrap any `GlobalAlloc`, such as `mimalloc`.
nvzqz
force-pushed
the
feat/alloc
branch
4 times, most recently
from
437fe5e
to
bcabfea
Compare
nvzqz
force-pushed
the
feat/alloc
branch
6 times, most recently
from
2c8cfde
to
d34d708
Compare
This generally performs better than `thread_local!`. A later commit will optimize it further by looking up the pthread-specific variable in the linear table whose address is stored in `gs` on x86_64 and `tpidrro_el0` on AArch64.
This removes the need to implement reuse via `thread_local!` drop.
This does the same work as `pthread_{get,set}specific` by indexing into
the thread-specific data table via the address obtained from the
`gs`/`tpidrro_el0` register on x86_64/AArch64 respectively.
This change also aligns some atomic variables with a new `CachePadded`
type to prevent false sharing between threads of variables on the same
cache line.
|
I believe I've pored over this code enough to be convinced that it's correct, so I'm going to merge it. Also, I can't come up with ways to make it faster without spending much more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
AllocProfiler, an allocator implementation that tracks the number of allocations and bytes allocated during benchmarks. It can wrap anyGlobalAlloc, such asmimalloc.Example benchmark output: