Fix another crash with devtools timeline #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…rs. (patchset #13 id:240001 of https://codereview.chromium.org/776923003/) Reason for revert: This caused a lot of virtual/slimmingpaint failures. I'm sure many are rebaselines, however tests such as these: virtual/slimmingpaint/fast/block/positioning/relative-overflow-block.html virtual/slimmingpaint/fast/block/positioning/relative-overflow-replaced-float.html virtual/slimmingpaint/fast/block/positioning/relative-overflow-replaced.html mention explicitly that scrollbars should appear, and they don't, so it looks like those tests regressed. Original issue's description: > Implement Slimming Paint for scrollbars and scrollbar corners. > > It's implemented twice: once for individually composited scrollbar pieces, and > once for software. > > Also remove unnecessary and redundant transforms when painting via RenderLayerCompositor. > > BUG=438356 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186633 TBR=pdr@chromium.org,chrishtr@chromium.org NOTREECHECKS=true NOTRY=true BUG=438356 Review URL: https://codereview.chromium.org/767493003 git-svn-id: svn://svn.chromium.org/blink/trunk@186656 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
pushed a commit
to jtg-gg/blink
that referenced
this pull request
Jul 31, 2015
…ane. (patchset nwjs#13 id:230001 of https://codereview.chromium.org/1052993006/) Reason for revert: PasswordManagerBrowserTest.NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage is broken by this change. Original issue's description: > Refactor frame navigation/detach state cleanup to be more sane. > > Prior to this patch, cleaning up state for a navigating or detaching > frame was ad hoc: often times, code to do the same thing (e.g. detach > child frames) was present in multiple locations just to "be sure" that > the cleanup would happen no matter what code path was taken. > > This logic has been reorganized so that the state cleanup always follows > a similar flow for both navigation and detach. There are now 4 common > steps: > 1. FrameLoader::dispatchUnloadEvent() > 2. Frame::detachChildren() > 3. Document::prepareForDestruction() > 4. FrameLoader::clear() > > BUG=464764 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193157 TBR=japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464764 Review URL: https://codereview.chromium.org/1058403002 git-svn-id: svn://svn.chromium.org/blink/trunk@193158 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.