-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide title for frameless window #6
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged into the master patch. |
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
This patch enables drag-and-drop to work across out-of-process iframes. BUG=647249, 655063 Review-Url: https://codereview.chromium.org/2508013002 Cr-Commit-Position: refs/heads/master@{#433068} (cherry picked from commit 90572ae) Review URL: https://codereview.chromium.org/2517653003 . Cr-Commit-Position: refs/branch-heads/2924@{#6} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
…tchset #6 id:100001 of https://codereview.chromium.org/2468863002/ ) Reason for revert: Regressed crbug.com/647393. Original issue's description: > scheduler: Re-enable timer throttling for hidden frames > > Turn hidden timer throttling back now that the issue with Gmail pop-ups > not working has been resolved by https://codereview.chromium.org/2272773002/. > > This patch also fixes a timer throttling related rebase error in a > previous patch and adds new layout test that cover out-of-view timer > and requestAnimationFrame throttling. > > Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_Lhz8THHk2Q > > BUG=616519,647393 > > Committed: https://crrev.com/1688130897aed95d32e3904a6aa10384414fbefe > Cr-Commit-Position: refs/heads/master@{#432642} TBR=kinuko@chromium.org,ojan@chromium.org,ojan@google.com BUG=616519,647393 Review-Url: https://codereview.chromium.org/2511283002 Cr-Commit-Position: refs/heads/master@{#433061} (cherry picked from commit 32461cc) Review URL: https://codereview.chromium.org/2520953002 . Cr-Commit-Position: refs/branch-heads/2924@{#27} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
…set #6 id:100001 of https://codereview.chromium.org/2306143002/ ) Reason for revert: After this change, Chrome keeps crashing on the login screen (reproduced on a minnie device). Original issue's description: > Plumbing for login apps device policy to extensions. > > This CL succeeeds the CL #2150483004 > > ChromeProcessManagerDelegate: > * Enable background pages for apps in the login profile when > command-line switch --enable-login-apps is set. > > ExtensionManagement: > * Factor out common code into GetInstallListByMode from > GetForceInstallList and GetRecommendedInstallList. > * Common function UpdateForcedExtensions. > > ExtensionSystemImpl: > * Enable extensions in login profile when command-line switch > --enable-login-apps is set. > > ExternalProviderImpl: > * In CreateExternalProviders, create an ExternalPolicyLoader for login > apps in the login profile. > > ExtensionInstallListPolicyHandler: > * Common base class to parse login and force extension install lists. > > * Switch --enable-login-apps to enable login apps. > * Extension pref extensions.install.loginlist. > > BUG=576464 > > Committed: https://crrev.com/3bbfabe266cd5138393d3e87229de567d19da005 > Cr-Commit-Position: refs/heads/master@{#432917} TBR=emaxx@chromium.org,asargent@chromium.org,bartfab@chromium.org,achuith@chromium.org,antrim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=576464 Review URL: https://codereview.chromium.org/2525483004 . Cr-Commit-Position: refs/branch-heads/2924@{#64} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
rogerwang
pushed a commit
that referenced
this pull request
Dec 8, 2016
…tion. (patchset #6 id:100001 of https://codereview.chromium.org/2496283004/ ) Reason for revert: Computing these image regions adds significant time to the critical path on image heavy content. Let's re-land after addressing the performance. BUG=670926 Original issue's description: > cc: Build Image to Region map during image meta-data generation. > > During the discardable image meta-data generation phase, we build an > Rtree to pull the set of images given a rect. This change adds a > reverse lookup map to be built at the same time for querying the region > for an image in a DisplayItemList. > > BUG=665266 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Committed: https://crrev.com/fc85c1aa0881047c4410cbedc1e4543bcf789a1f > Cr-Commit-Position: refs/heads/master@{#432841} TBR=vmpstr@chromium.org,khushalsagar@chromium.org BUG=665266 Review-Url: https://codereview.chromium.org/2551583003 Cr-Commit-Position: refs/heads/master@{#436174} (cherry picked from commit 654417a) Review URL: https://codereview.chromium.org/2552903002 . Cr-Commit-Position: refs/branch-heads/2924@{#347} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
rogerwang
pushed a commit
that referenced
this pull request
Mar 8, 2017
…160001 of https://codereview.chromium.org/2583873002/ ) Reason for revert: Breaking M57 crbug/698627 Original issue's description: > Correctly update the popup window position > > It was updating the child window instead. > This CL hooks up the bounds change to the desktop widget correctly. > > BUG=612270 > TEST=fixed test harness to do the correct check. > > Review-Url: https://codereview.chromium.org/2583873002 > Cr-Commit-Position: refs/heads/master@{#442741} > Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org BUG=612270, 698627 Review-Url: https://codereview.chromium.org/2728293004 Cr-Commit-Position: refs/heads/master@{#455231} (cherry picked from commit 2ba9b1f) Review-Url: https://codereview.chromium.org/2732383002 . Cr-Commit-Position: refs/branch-heads/2987@{#791} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
If a lite-page is requested and the server does not provide one, Chrome should request a Lo-Fi image on subresources. However, Chrome should not request empty-image on the subresource requests of a Weblite page. BUG=660212 Review-Url: https://codereview.chromium.org/2642793005 Cr-Commit-Position: refs/heads/master@{#454638} (cherry picked from commit 3f4bae9) Review-Url: https://codereview.chromium.org/2732773002 . Cr-Commit-Position: refs/branch-heads/3029@{#6} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
rogerwang
pushed a commit
that referenced
this pull request
Mar 16, 2017
…160001 of https://codereview.chromium.org/2583873002/ ) Reason for revert: Breaking M57 crbug/698627 Original issue's description: > Correctly update the popup window position > > It was updating the child window instead. > This CL hooks up the bounds change to the desktop widget correctly. > > BUG=612270 > TEST=fixed test harness to do the correct check. > > Review-Url: https://codereview.chromium.org/2583873002 > Cr-Commit-Position: refs/heads/master@{#442741} > Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org BUG=612270, 698627 Review-Url: https://codereview.chromium.org/2728293004 Cr-Commit-Position: refs/heads/master@{#455231} (cherry picked from commit 2ba9b1f) Review-Url: https://codereview.chromium.org/2747723004 . Cr-Commit-Position: refs/branch-heads/3029@{#159} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
…ps://codereview.chromium.org/2815453006/ ) Reason for revert: Reason for revert: https://codereview.chromium.org/2653923008/ is suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Introduce ModulePendingScript > > BUG=594639 > > Review-Url: https://codereview.chromium.org/2815453006 > Cr-Commit-Position: refs/heads/master@{#464627} > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59a88f77bb50f5 TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594639 Review-Url: https://codereview.chromium.org/2816043005 Cr-Commit-Position: refs/heads/master@{#464765} (cherry picked from commit 80f482b) Review-Url: https://codereview.chromium.org/2825523002 . Cr-Commit-Position: refs/branch-heads/3071@{#16} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
rogerwang
pushed a commit
that referenced
this pull request
Jul 17, 2017
In some videos uploaded from cameras, the first frame in presentation order is not the first frame in decode order. The metadata correctly records this. However, FFmpeg is adjusting timestamps so that the first frame in decode order is at time 0. As a result, the first frame in presentation order has a negative timestamp, which produces an error. The workaround is to pass "advanced_editlist=0" in the demuxer options. This avoids the problem until FFmpeg fixes it properly. BUG=723537 TEST=tested locally with example from comment #6 in the bug (cherry picked from commit 916a829) TBR=jrummell@chromium.org Change-Id: I2b515dff06da2930339592ff4e84ec69da635c91 Reviewed-on: https://chromium-review.googlesource.com/526752 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#477887} Reviewed-on: https://chromium-review.googlesource.com/546916 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#457} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
rogerwang
pushed a commit
that referenced
this pull request
Jul 20, 2017
This reverts commit 1b60006. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0cd134a) Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#487191} Signed-off-by: Bernie Thompson <bhthompson@google.com> Reviewed-on: https://chromium-review.googlesource.com/575149 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#623} Cr-Branched-From: b6460e2-refs/heads/master@{#474897}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
TBR=dimu@chromium.org Change-Id: I447058b78a79d3dbc80b742844bbb14fad8e3e37 Reviewed-on: https://chromium-review.googlesource.com/581856 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#6} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
rogerwang
pushed a commit
that referenced
this pull request
Aug 17, 2017
…tchset #6 id:220001 of https://codereview.chromium.org/2931833004/ ) Reason for revert: introduced crbug/750775 Original issue's description: > Always set the navigation pending item for page reload. > > Set the pendingItemIndex to the last committed item in case of page reload > and on the case of application open/tab out of memory reopened. > > This doesn't solve the PendingItem being null problem entirely there are still > couple cases when that can happen and they are not page reloads. > > CL 1/2 > > BUG=676129 > > Review-Url: https://codereview.chromium.org/2931833004 > Cr-Commit-Position: refs/heads/master@{#486777} > Committed: https://chromium.googlesource.com/chromium/src/+/bc2e0a45e23c739bb3c04d119d43abbb01398289 TBR=eugenebut@chromium.org, kkhorimoto@chromium.org, mrefaat@chromium.org BUG=676129 (cherry picked from commit d7d7325) Review-Url: https://codereview.chromium.org/2998463002 Cr-Original-Commit-Position: refs/heads/master@{#492138} Change-Id: I53f42b2ed052a05fcfdf429a9098e77bfd4d70c2 Reviewed-on: https://chromium-review.googlesource.com/612486 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#495} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
> This reverts commit cd8bc9f. > > Reason for revert: Breaks thestig@'s theme. Also, ShouldWindowContentsBeTransparent() should only return true on the Windows Aero theme > > Original change's description: > > X11: Fix transparency on certain windows > > > > Transparency on arrow windows stopped working after CL [1]. This CL > > is a one-line selective revert of that CL. Note that transparency on > > all other windows that I've tested (drag images, dragged URLs, etc) > > were not broken. > > > > [1] https://chromium.googlesource.com/chromium/src/+/5785866a9b2a0db4854552eb87af7229d4b11a43 > > > > BUG=758304 > > R=erg@chromium.org > > > > Change-Id: I37020d930bd081facce65b0a8be0eeb2e1756c69 > > Reviewed-on: https://chromium-review.googlesource.com/629538 > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Elliot Glaysher <erg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#496775} > > TBR=erg@chromium.org,thomasanderson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 758304 > Change-Id: I5fa80e041c77d485afa08dea99d893f84474c458 > Reviewed-on: https://chromium-review.googlesource.com/647032 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#499131} > BUG=758304 TBR=erg@chromium.org CC=thestig@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I5e69899078d27d1b24b95ee2d02a84a8db6270ee Reviewed-on: https://chromium-review.googlesource.com/648089 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#6} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
TBR=dimu@chromium.org Change-Id: I2714f4717c4daff05ed490f5dbe9962bf6ca0f9b Reviewed-on: https://chromium-review.googlesource.com/719938 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#6} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
TBR=dimu@chromium.org Change-Id: I4622e0a04eb0a61ab87df35d4dfacf187e2113dd Reviewed-on: https://chromium-review.googlesource.com/877421 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#6} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
TBR=dimu@chromium.org Change-Id: I13d8061ab6f6fcbf371b1fd7d9183f4532d5dc6d Reviewed-on: https://chromium-review.googlesource.com/947832 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#6} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
Disable overscroll history navigation on Windows Touchpad with feature flag. This CL also wraps all changes in crrev/c/98210 and crrev/c/1003214 behind this flag. This CL also disable overscroll history navigation on Linux Touchpad since we will set has_precise_delta for Linux soon. Bug: 647140 Change-Id: Id08654bf20b3ada7b5e75f2308a915efeed0e934 Reviewed-on: https://chromium-review.googlesource.com/1002866 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mohsen Izadi <mohsen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550508}(cherry picked from commit cd44c76) Reviewed-on: https://chromium-review.googlesource.com/1013221 Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#6} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
TBR=mmoss@chromium.org Change-Id: Ie35e5dd24231ebd60c743375efda2db907941ca8 Reviewed-on: https://chromium-review.googlesource.com/1073810 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#6} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
TBR=amineer@chromium.org Change-Id: I20b6c12f29ac2bdaa2ce7690046680ff367fbf96 Reviewed-on: https://chromium-review.googlesource.com/1145712 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#6} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
Change-Id: I771913faa8dc94b6a426d69045eac86e8e6959e0 Reviewed-on: https://chromium-review.googlesource.com/1199926 Reviewed-by: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#6} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
Speculative fix that the webrtc m71 branch is out-of-sync with src.git and the cause of build failures. R=govind@google.com, tommi@google.com Bug: 895012 Change-Id: Ibd19f2371b6eda5d915ce4ebf9ba377e507ff0c6 Reviewed-on: https://chromium-review.googlesource.com/c/1279345 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#6} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
This reverts commit ffea867. Reason for revert: The WebRTC M71 branch has been fixed, so re-pin to it. Tested OK locally syncing deps and building with this revert. Here's the fixed WebRTC M71 branch: https://webrtc.googlesource.com/src/+log/branch-heads/71 Original change's description: > Revert webrtc unpinning. > > Speculative fix that the webrtc m71 branch is out-of-sync with src.git > and the cause of build failures. > > R=govind@google.com, tommi@google.com > > Bug: 895012 > Change-Id: Ibd19f2371b6eda5d915ce4ebf9ba377e507ff0c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1279345 > Reviewed-by: Krishna Govind <govind@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#6} > Cr-Branched-From: 4226ddf-refs/heads/master@{#599034} TBR=tommi@chromium.org,mmoss@chromium.org,govind@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895012 Change-Id: I4fe1be11eb845e36f752d05687bb7acf7af2b267 Reviewed-on: https://chromium-review.googlesource.com/c/1280666 Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#25} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
The original change fixed the bounds for app list window, but not for its parent, so the issue is not fixed entirely. Fix it for the parent window in this CL. Bug: 884889 Change-Id: I6a48bae85fd3d89957d58a4aabf270c7df288d5d Reviewed-on: https://chromium-review.googlesource.com/c/1282386 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#600054}(cherry picked from commit 3cabcd8) Reviewed-on: https://chromium-review.googlesource.com/c/1287046 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3575@{#6} Cr-Original-Branched-From: 16ca0c3-refs/heads/master@{#597882}(cherry picked from commit efe4bb9b77874ce4d94c53da7d40d5a06fd5691c) Reviewed-on: https://chromium-review.googlesource.com/c/1294872 Cr-Commit-Position: refs/branch-heads/3578@{#247} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
TBR=cmasso@chromium.org Change-Id: I5b49da60febc183f25a68dc7b69a4eb351dce2ff Reviewed-on: https://chromium-review.googlesource.com/c/1357904 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#6} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
TBR=mmoss@chromium.org Change-Id: I3e399782de59552ad65c2dba2bc8c1732b9fb2de Reviewed-on: https://chromium-review.googlesource.com/c/1437522 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#6} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
TBR=cmasso@chromium.org Change-Id: Ic7470d329a4fe6cee03e41374730498491dca836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513118 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#6} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed nwjs/nw.js#4507