-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreadable buttons in alert() and prompt() dialogs [$100] #433
Comments
I can confirm similar problem on Vista as well. |
This issue still exists with latest node webkit build and windows xp. (not tested on other windows versions)... |
This issue also exists with the latest node webkit build and Window 7. I am using it for a confirm dialog . |
Same issue (nw 0.8 + xp + confirm and alert). Any update? |
Same issue on windows 7 32bit and node-webkit v0.10.1-win-ia32 |
Same problem with windows xp + nw 0.10.5 |
It worked much better on pc when I used 'window.alert' instead of just 'alert'. |
Bug is still present (NW v0.10.5, Windows 7 Pro). Please note that with alert() and confirm() (same problem with window.alert() and window.confirm()):
@CarmelK : Not on Win 7 Pro here. |
Just to add - this is a problem on Win7 if you disable Aero - it seems OK (at least for me) if you have Aero enabled - checked in latest version (W764 here) |
@rogerwang Any idea what could be causing this? It's realy disturbing and dates back 2 years... |
will look to fix it soon. |
@rogerwang When would you like to look into it ? |
Hi guys, any news on this? :) |
Quite a weird issue, and really disturbing. Any ideas? |
Just as @Mithgol said, the real problem is about the compatibility of chromium of old windows system. As you know, such basic javascript code is handled by chromium module itself. Anyway, both alert() and prompt() dialog work well on my win7-64bit. |
Note: it has NOTHING to do with "older systems", there are plenty of 'newer systems' which run Windows7 without Aero (some software doesn't work well with it - some hardware isn't good enough and as someone said, there are versions of W7 which don't have it!!) I've been doing a bit of work with a similar project to nw.js - atom-shell - and I came across a comment by the developer who was explaining that all the "dialog" windows (generated by alert, confirm, prompt) have to be coded manually per-platform and that was something he wouldn't be doing because there were easy alternatives such as http://tristanedwards.me/sweetalert and http://fabien-d.github.io/alertify.js/ - more here too http://webuilddesign.com/6-javascript-tools-to-create-cool-user-alert/ ... So I'm in the process of gutting-out all my usage of alert/prompt/confirm as I type - I like the more 'styleable' CSS approach anyway - thought I'd leave this here for anyone who runs into this in future tho |
While CSS-based solutions are great in most cases, in the case of our project we rely quite a bit on the blocking nature of |
CSS-based alerts offer a variety of 'modal' options - the simplest of which The only real downside to a CSS dialog (much like a CSS contextmenu or a On 13 March 2015 at 02:50, Gueorgui Tcherednitchenko <
|
It's not just "Aero"... It's Win 7 presentation styles (not sure what is going to happen on winXp). By disabling them from MyComputer>Properties>Advanced>Performance will make the dialog buttons visible, but your desktop will look like Win95. Workaround |
I'll try that. But that doesn't fix the problem for the users of my app, 2015-04-28 11:24 GMT+02:00 mbrami76 notifications@github.com:
|
@pVesian for current users they should do it by themselves, or you could ship a patch with a windows registry update to permanently adopt the compatibility mode just for your application (see this for more info: http://www.verboon.info/2011/03/running-an-application-as-administrator-or-in-compatibility-mode/). Unfortunately I couldn't find any command-line switch or option to enable this, and if anyone has info on this it would be highly appreciated. |
Suggesting people hack the registry/change system settings to make dialogs Using CSS-based dialogs is a better solution because it's making proper Also - I think nw.js needs to address this properly by either a - fixing it On 28 April 2015 at 16:29, mbrami76 notifications@github.com wrote:
|
Totally agree that this is not the way. That's why it's called a workaround. By the way changing the registry the way it is suggested it's not exactly a hack, but a normal operation: every single application you are going to install on windows quite "hacks" the registry, and such a change it is supposed not going to affect any other application, since it is application-specific.
On this I do not agree, because you are assuming that any app is consistently more robust than the platform: I don't think this is realistic. Alerts and Confirms are designed to be native to the OS (and not the application) because are supposed to be a bit more reliable and robust. In my opinion the proper solution is to fix the issue and continue using system dialogs. |
Just to be clear, the reason this issue exists is because those dialogs are In nw.js there is this issue and it's been there a LONG time - in I'm not entirely sure a browser should be throwing 'OS-style' dialogs at a Whatever tho, this bug had been around for a long time - may be around for On 28 April 2015 at 21:30, mbrami76 notifications@github.com wrote:
|
It will be fixed in the upcoming nw13 version. |
nw13 not support NPAPI,while nw12 is still with this bug...this is really disturbing |
Close as it's fixed in nw13. @TateHuang how is NPAPI related to the alert dialog? |
On Windows XP, the alert() and prompt() windows have hardly readable buttons.
On Windows 7, it works properly.
https://groups.google.com/d/topic/node-webkit/mByrzqMeMYU/discussion
There is a $100 open bounty on this issue. Add to the bounty at Bountysource.
The text was updated successfully, but these errors were encountered: