Config setting to only yield complete lines #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check the failures next week. |
|
Turns out I just misunderstood one of the test helpers and by not changing some names in tests, I created a race condition. Renaming those tests fixe the issue (tests still running, but I'm gonna call it 😁 ). |
nxadm
reviewed
Nov 2, 2021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file writer doesn't flush line by line, it can (and does) happen that we get partial lines from the tailer. And worse, we can't even detect this and buffer these partials, because the library doesn't expose this fact.
This PR aims to change this - it learns from previous implementations that partially addressed this and introduces a new option (and thus is backwards compatible) to enable this explicitly.
(Discussed in #25.)