Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.3 #7

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Release 0.1.3 #7

merged 4 commits into from
Dec 7, 2023

Conversation

nxsaken
Copy link
Owner

@nxsaken nxsaken commented Dec 7, 2023

  • Implement more iterator traits
  • Make library generic over signed integers
  • Update benchmarks

@nxsaken nxsaken merged commit d21d939 into main Dec 7, 2023
1 check passed
@nxsaken nxsaken deleted the release-0.1.3 branch December 7, 2023 15:20
@bend-n
Copy link

bend-n commented Dec 15, 2023

This version does not compile.

error[E0445]: crate-private trait `Constant` in public interface
   --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clipline-0.1.3/src/util.rs:190:1
    |
190 | / pub fn bresenham_step<T>(
191 | |     mut err: T,
192 | |     mut xyd: T,
193 | |     mut yxd: T,
...   |
199 | | where
200 | |     T: Ord + AddAssign + SubAssign + Constant<Output = T>,
    | |__________________________________________________________^ can't leak crate-private trait
...
212 |   pub(crate) trait Constant {
    |   ------------------------- `Constant` declared as crate-private

@nxsaken
Copy link
Owner Author

nxsaken commented Dec 15, 2023

That's weird, but Pixels CI also broke today because of this. I thought it was allowed to use private trait bounds, and the new version even works in my other project. I wonder what changed. Yanked the latest release anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants