nxus-searcher-preset #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottMaxson
approved these changes
Nov 5, 2018
loppear
commented
Nov 6, 2018
| // But let nxus startup actually create the index with settings | ||
| await super.setup() | ||
|
|
||
| this.global.tester.searcherRefresh = async () => { |
There was a problem hiding this comment.
@ScottMaxson asks "why is this being added to the global here".
So this refresh function only makes sense to me at the intersection of tests/nxus/searcher, so I think it makes sense to live in this preset's environment. But I didn't think it should introduce a new global so I'm adding it into the tester namespace. Open to other suggestions. Maybe it makes sense as a method on searcher itself and I'm wrong about only using it in tests. In that case, tests would use application.get('searcher').refreshIndex() say. But waterline-elasticsearch doesn't expose this client method directly so it would still look like a hack there a bit. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a preset and environment for nxus apps using searcher / elasticsearch to manage setup/teardown of an ephemeral search index.
Also gets rid of the jest-nxus.config.js file and reads the main jest
testEnvironmentOptionskey instead for overriding server and env settings.