Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autopixie.py #1

Merged
merged 1 commit into from
Apr 15, 2015
Merged

Update autopixie.py #1

merged 1 commit into from
Apr 15, 2015

Conversation

d8tahead
Copy link
Contributor

Removed tailing " and XXXXXb == "": " from
if "XXXXX" in line and XXXXXb == "":
such, because will mix hash information. it is needed to start fresh each new attempt for proper usage

fixed some regex to hex only ranges [^A-Fa-f0-9]+ instead of un-needed [^A-Za-z0-9]+ non hex only ranges for hex values

Removed tailing " and XXXXXb == "": " from
if "XXXXX" in line and XXXXXb == "":
such, because will mix hash information. it is needed to start fresh each new attempt for proper usage

fixed some regex to hex only ranges [^A-Fa-f0-9]+ instead of un-needed [^A-Za-z0-9]+ non hex only ranges for hex values
nxxxu added a commit that referenced this pull request Apr 15, 2015
@nxxxu nxxxu merged commit 5d0c0dd into nxxxu:master Apr 15, 2015
@nxxxu
Copy link
Owner

nxxxu commented Apr 15, 2015

i would challenge you on that, i dont see it doing what you say.
because after the reaver() it deletes the reaver outputs, and when it
starts to reave hashes from another client, it goes to reaver() and in the
beginning there is hash="" and hashb="" wich empties them.
im not saying if "E-Hash2" in line and EHash2b == "": is necessary, was
implemented when it said in status, hash found, didnt want it to spam
PKE/Authkey hash if it didnt recieve hash1-2

and re.sub('[^A-Fa-f0-9]+, i dont see it really making any difference.

i dont see the changes qould make any difference what so ever in the python
script, i now changed that,, but i dont see any difference in the way it
works.
you are ofc welcome to explain why you think it would collide.. but yeah,
its merged now.

2015-04-15 9:43 GMT+03:00 d8tahead notifications@github.com:

Removed tailing " and XXXXXb == "": " from
if "XXXXX" in line and XXXXXb == "":
such, because will mix hash information. it is needed to start fresh each
new attempt for proper usage

fixed some regex to hex only ranges [^A-Fa-f0-9]+ instead of un-needed

[^A-Za-z0-9]+ non hex only ranges for hex values

You can view, comment on, or merge this pull request online at:

#1
Commit Summary

  • Update autopixie.py

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1.

@d8tahead
Copy link
Contributor Author

I meant no offence, your code is good. But I've had some instances where it wouldn't clear them out.
that was the reasoning behind me also putting the output of the full hashes on screen in the version I had posted on the forums. But then again I do have a few versions of reaver that I've modified for testing in different ways.
Any who, if you see no difference in the output, then revert the change.
But if anything, if it essentially is the same for you, it removes an unneeded check.

But you've done some great work, keep it up. :-)

@d8tahead
Copy link
Contributor Author

As for the regex, it's just for probably not even barely noticeable performance reasons. all its doing is eliminating a check a-Z. All that is needed is to a-F.
I run this script like many others on a tablet, not a nexus7, but an older a500. And I need to spare all the cpu cycles I can :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants