Line handlers #114
Line handlers #114
Conversation
handlers/line/line.go
Outdated
|
|
||
| } | ||
|
|
||
| return []courier.Event{msgs[0]}, courier.WriteMsgSuccess(ctx, w, r, msgs) |
There was a problem hiding this comment.
Should be returning all msgs, not just [0]
| // }, | ||
| // { | ||
| // "replyToken": "nHuyWiB7yP5Zw52FIkcQobQuGDXCTA", | ||
| // "type": "follow", |
There was a problem hiding this comment.
Do we not support follows?
There was a problem hiding this comment.
I guess if we don't support it in the past that's ok to leave it off for now.
handlers/line/line.go
Outdated
| if len(lineRequest.Events) > 0 { | ||
| return nil, courier.WriteAndLogRequestIgnored(ctx, w, r, channel, "ignoring request, no message") | ||
| } | ||
| return nil, courier.WriteAndLogRequestError(ctx, w, r, channel, fmt.Errorf("missing message, source or type in the event")) |
There was a problem hiding this comment.
Not sure I understand this case.. is this really an error?
There was a problem hiding this comment.
If the events list was empty we return an error, otherwise the event were just ignored by us
There was a problem hiding this comment.
Seems if the list is empty we should just ignore it too, if its valid JSON that's just fine.
| if err != nil { | ||
| return status, err | ||
| } | ||
| status.SetStatus(courier.MsgWired) |
There was a problem hiding this comment.
Any external id to parse?
There was a problem hiding this comment.
the docs says they just return a 200 and and empty JSON
handlers/line/line.go
Outdated
| ) | ||
|
|
||
| var sendURL = "https://api.line.me/v2/bot/message/push" | ||
| var maxMsgLength = 1600 |
There was a problem hiding this comment.
Do we know what this is exactly from their API docs?
There was a problem hiding this comment.
I see it is 2000 on the docs, I update that
Fixes #96