Support FCM changes #762
Merged
Support FCM changes #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkans7
commented
Jul 24, 2024
handlers/firebase/handler.go
Outdated
|
|
||
| sendURL := fmt.Sprintf("https://fcm.googleapis.com/v1/projects/%s/messages:send", fcmAuthJSON["project_id"]) | ||
|
|
||
| ts, err := idtoken.NewTokenSource(ctx, sendURL, option.WithCredentialsJSON([]byte(fcmAuthJSONString))) |
There was a problem hiding this comment.
Use the credentials JSON to make a token source and we use REST API for the requests with the Bearer access token
https://cloud.google.com/docs/authentication/get-id-token#go
norkans7
force-pushed
the
firebase-tokens
branch
from
fe02db5
to
33d97fe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 75.88% 76.11% +0.23%
==========================================
Files 111 111
Lines 10394 10699 +305
==========================================
+ Hits 7887 8144 +257
- Misses 1788 1825 +37
- Partials 719 730 +11 ☔ View full report in Codecov by Sentry. |
norkans7
changed the title
rowanseymour
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.