This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
forked from jessemiller/HamlPy
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
suggested changes
Jan 23, 2017
@@ -37,6 +37,10 @@ def plain(content, indent, options): | |||
return textwrap.dedent(content) | |||
|
|||
|
|||
def preserve(content, intent, options): | |||
return textwrap.dedent(content.replace('\n', ' ').replace('\r', ' ')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should match https://github.com/haml/haml/blob/master/lib/haml/helpers.rb#L132
Error with :highlight filter is caused by my commit? |
rowanseymour
suggested changes
Jan 26, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the pygments problem in master, so please update this branch against that.
@@ -37,6 +37,13 @@ def plain(content, indent, options): | |||
return textwrap.dedent(content) | |||
|
|||
|
|||
def preserve(content, intent, options): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, intent -> indent
rowanseymour
approved these changes
Jan 26, 2017
@shooz looks good, thanks! |
Closed
Made new release with this https://pypi.python.org/pypi/django-hamlpy/1.0.1 |
ghost
deleted the
preserve-filter
branch
January 28, 2017 21:23
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.