Saving Improvements #846
Merged
Saving Improvements #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnewcomer
commented
Mar 17, 2020
| this.props.mergeEditorState({ activityInterval: ACTIVITY_INTERVAL }); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is addressing a react warning. This is moved to the save method so that components can't update themselves after render.
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 63.98% 63.97% -0.02%
==========================================
Files 171 171
Lines 6514 6523 +9
Branches 1522 1522
==========================================
+ Hits 4168 4173 +5
- Misses 1829 1833 +4
Partials 517 517
Continue to review full report at Codecov.
|
ericnewcomer
commented
Mar 17, 2020
| @@ -237,8 +238,13 @@ | |||
| "type_label": "When a contact arrives at this point in your flow..." | |||
| }, | |||
| "groups": "Groups", | |||
| "issue": { | |||
| "legacy_extra": "Invalid regular expression found: [[regex]]" | |||
| }, | |||
There was a problem hiding this comment.
missed some i18n on issues
nicpottier
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to address possibility of stale implicit saving and save lockout. Also adds a separate monitor to check for stale changes.