Send to all urns #49
Merged
Send to all urns #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicpottier
reviewed
Jul 7, 2017
flows/actions/reply.go
Outdated
| run.AddEvent(step, events.NewSendMsgToContact(run.Contact().UUID(), text, a.Attachments)) | ||
| urns := run.Contact().URNs() | ||
| if a.AllURNs && len(urns) > 0 { | ||
| for i := range urns { |
There was a problem hiding this comment.
This may be a question of how we expect this to work for contacts that have no URNs but I think the more go-ing way of doing this would probably be:
if a.AllURNS {
for _, urn := range run.Contact().URNS() {
run.AddEvent(step, events.NewSendMsgToURN(urn, text, a.Attachments))
}
} else {
...
}
nicpottier
reviewed
Jul 7, 2017
| @@ -48,6 +48,16 @@ | |||
| "text": "Hi @contact.name, are you ready?" | |||
| }, | |||
| { | |||
| "uuid": "ac110f56-a66c-4462-921c-b2c6d1c6dadb", | |||
| "type": "send_msg", | |||
There was a problem hiding this comment.
I don't think this means what you think it means. :)
nicpottier
approved these changes
Jul 7, 2017
rowanseymour
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #45