Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine the completion.json and functions.json editor support files into a single editor.json file #995

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

rowanseymour
Copy link
Member

Does #991. Still outputs the original files as well for backward compatibility

{
  "context": { ... what used to be in completion.json ..   }
  "functions": { ... what used to be in functions.json ..   }
}

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #995 (10ca2f3) into master (3b9019a) will decrease coverage by 0.09%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
- Coverage   86.10%   86.01%   -0.10%     
==========================================
  Files         235      234       -1     
  Lines       10305    10322      +17     
==========================================
+ Hits         8873     8878       +5     
- Misses       1020     1026       +6     
- Partials      412      418       +6     
Impacted Files Coverage Δ
cmd/docgen/docs/editor_support.go 75.00% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9019a...10ca2f3. Read the comment docs.

@rowanseymour rowanseymour merged commit 0d7976c into master Jan 15, 2021
@rowanseymour rowanseymour deleted the single_editor_support_file branch January 15, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants