Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/tree shaking #11

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Chore/tree shaking #11

merged 3 commits into from
Jul 23, 2021

Conversation

sdwvit
Copy link
Contributor

@sdwvit sdwvit commented Jul 22, 2021

  • Reorginize code in a way that allows esbuilt to strip off unused stores, when building a specific component.
    E.g. Agenda doesn't care about ContactStore
  • Adopt nylas eslint plugin for svelte
  • nylas-error was not included in any of the component, since it required implicit import. Fix that by importing it in commons and telling esbuilt to not tree-shake it
  • fix typescript warnings here and there

@vercel
Copy link

vercel bot commented Jul 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nylas/components/FhgqtNYc2G63h3MhqatsZkY5p1p1
✅ Preview: https://components-git-sdwvit-choretree-shaking-nylas.vercel.app

@sdwvit sdwvit requested review from a team, philrenaud and ozsivanov and removed request for a team July 22, 2021 18:44
@sdwvit sdwvit self-assigned this Jul 22, 2021
@sdwvit sdwvit requested a review from AaronDDM July 22, 2021 18:45
Copy link
Collaborator

@wonka-lighthouse wonka-lighthouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile http://localhost:8000/components/agenda/src/index.html

Device URL
mobile http://localhost:8000/components/composer/src/index.html

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@sdwvit sdwvit merged commit 52968d1 into main Jul 23, 2021
@sdwvit sdwvit deleted the sdwvit/chore/tree-shaking branch July 23, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants