[Mailbox] Implemented server-side pagination #217
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nylas/components/72LUW9NxoJ5gP8ELXGu12EDFGg12 |
|
This pull request has been linked to Shortcut Story #74056: Mailbox component - unable to page past initial threads. |
| const queryKey = JSON.stringify(query); | ||
| if (!threadsMap[queryKey] && (query.component_id || query.access_token)) { | ||
| threadsMap[queryKey] = [await fetchThread(query)]; | ||
| updateThreadSelection: ( |
There was a problem hiding this comment.
TODO - revisit if this is needed
There was a problem hiding this comment.
Do we still need this?
| if (_this.all_threads) { | ||
| threads = _this.all_threads as Thread[]; | ||
| if (_this.all_threads || !id) { | ||
| threads = (_this.all_threads as Thread[]) ?? []; |
There was a problem hiding this comment.
TODO - paginate onmount
ozsivanov
force-pushed
the
oz/ch74056/fixup-mailbox-pagination
branch
from
23ce5ec
to
aa001be
Compare
ozsivanov
force-pushed
the
oz/ch74056/fixup-mailbox-pagination
branch
from
aa001be
to
476ec97
Compare
ozsivanov
force-pushed
the
oz/ch74056/fixup-mailbox-pagination
branch
from
476ec97
to
d685056
Compare
| } else { | ||
| threads = (await MailboxStore.getThreads(query)) || []; | ||
| } | ||
| await updatedDisplayedThreads(); |
There was a problem hiding this comment.
updatedDisplayedThreads did you mean updateDisplayedThreads ?
There was a problem hiding this comment.
great catch, not sure how this isn't causing any errors
There was a problem hiding this comment.
oh I see, it's like this everywhere - needs to be renamed 👍
ozsivanov
force-pushed
the
oz/ch74056/fixup-mailbox-pagination
branch
from
d685056
to
be1b155
Compare
Code changes
unread_statusprop from Mailboxunreadprop from EmailLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.