Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContactList]: Changed default value of sort_by prop to name #58

Conversation

pooja169usp
Copy link
Contributor

@pooja169usp pooja169usp commented Sep 8, 2021

ContactList prop sort_by takes 2 possible value name & last_emailed.last_emailed requires that the account associated with the component have both contact & email scopes whereas name requires only contact scope.

Since, there could be users who essentially don't want to sort by last emailed, requiring additional email scope does not make sense. So, changing the default value to name

NOTE:
This change is also associated with a change in the middleware.

Readiness checklist

  • Cypress tests passing?

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@shortcut-integration
Copy link

@vercel
Copy link

vercel bot commented Sep 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nylas/components/98udKQ8VnKDw39dZoYVVWTJqxdRP
✅ Preview: https://components-git-poojaguggari-ch68516contact-list-co-c71ede-nylas.vercel.app

@@ -40,7 +40,7 @@ For both installation options, in the body of your page, you can instantiate the

## Using It in Your App

All Nylas components have two ways of dislaying data to your end-user:
All Nylas components have two ways of displaying data to your end-user:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo fix, not related to this PR.

@philrenaud
Copy link
Contributor

A little surprised this didn't cause a test error; could you add a test to init.spec.js ?

@pooja169usp
Copy link
Contributor Author

A little surprised this didn't cause a test error; could you add a test to init.spec.js ?

It wouldn't cause any errors so long as the account associated with it has both email & contact scopes.

@pooja169usp
Copy link
Contributor Author

Added below tests:
image

@pooja169usp pooja169usp merged commit db6b149 into main Sep 8, 2021
@pooja169usp pooja169usp deleted the poojaguggari/ch68516/contact-list-component-account-with-only branch September 8, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants