-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ContactList]: Changed default value of sort_by prop to name #58
[ContactList]: Changed default value of sort_by prop to name #58
Conversation
This pull request has been linked to Clubhouse Story #68516: [Contact-List Component] Account with only contacts scope remains loading for the Contact-List Component.. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nylas/components/98udKQ8VnKDw39dZoYVVWTJqxdRP |
@@ -40,7 +40,7 @@ For both installation options, in the body of your page, you can instantiate the | |||
|
|||
## Using It in Your App | |||
|
|||
All Nylas components have two ways of dislaying data to your end-user: | |||
All Nylas components have two ways of displaying data to your end-user: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a typo fix, not related to this PR.
A little surprised this didn't cause a test error; could you add a test to init.spec.js ? |
It wouldn't cause any errors so long as the account associated with it has both |
ContactList prop
sort_by
takes 2 possible valuename
&last_emailed
.last_emailed
requires that the account associated with the component have both contact & email scopes whereasname
requires only contact scope.Since, there could be users who essentially don't want to sort by last emailed, requiring additional email scope does not make sense. So, changing the default value to
name
NOTE:
This change is also associated with a change in the middleware.
Readiness checklist
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.