Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing is a Py35 backport; don't depend on it if you're above py35 #55

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

singingwolfboy
Copy link
Contributor

From https://pypi.org/project/typing/:

NOTE: in Python 3.5 and later, the typing module lives in the stdlib, and installing this package has NO EFFECT, because stdlib takes higher precedence than the installation directory.

and

For package maintainers, it is preferred to use typing;python_version<"3.5" if your package requires it to support earlier Python versions. This will avoid shadowing the stdlib typing module when your package is installed via pip install -t . on Python 3.5 or later.

Copy link
Contributor

@yusra-ahmed-zz yusra-ahmed-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@singingwolfboy singingwolfboy merged commit c91dfc6 into master Oct 27, 2020
@yusra-ahmed-zz
Copy link
Contributor

please remember to cut a new version and update our requirements.txt file!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants