Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the _get_shortname_from_docs method #67

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Deprecate the _get_shortname_from_docs method #67

merged 2 commits into from
Jun 4, 2021

Conversation

ecederstrand
Copy link
Contributor

It often causes more harm than actual benefit.

Upstream exchangelib has also removed this method.

Refs incident-20210527.

It often causes more harm than actual benefit.

Upstream exchangelib has also removed this method.

Refs incident-20210527.
Copy link
Contributor

@billwjo billwjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaghooli jaghooli merged commit 027875a into nylas:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants