Change pending unread notification stack to be a queue #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It always takes me a second to read a double negative, and be sure I understood correctly. It's also particularly troublesome for non-native English speakers.
Consider the case where a user launches N1, and has 3 unreads since their last launch. Additionally, after N1 has launched, they begin receiving a new mail every 2 seconds. Current behavior would be a notification for 1 of the 3 unread emails, then every 2 seconds a notification for the most recently received mail. They would only finally receive notifications for the other 2 original messages once they stopped getting new mail.
courajs
force-pushed
the
notification-queue
branch
from
eea9835
to
a70c634
Compare
|
Hi @courajs — thanks for submitting this. Looks great! Definitely better to have different subject lines for each email in those tests. Thanks— |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively minor, but I noticed it while poking around in the file, and
it started to bother me.
Consider the case where a user launches N1, and has 3 unreads since
their last launch. Additionally, after N1 has launched, they begin
receiving a new mail every 2 seconds.
Current behavior would be a notification for 1 of the 3 unread emails,
then every 2 seconds a notification for the most recently received mail.
They would only finally receive notifications for the other 2 original
messages once they stopped getting new mail.