Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calendars keyword for availability requests #350

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

thestrabusiness
Copy link
Contributor

@thestrabusiness thestrabusiness commented Mar 17, 2022

This commit adds an optional keyword argument calendar to the
Nylas::CalendarCollection's availability related methods. This is
parameter is accepted by the latest API, but was not previously included
in the method definitions.

The argument requirements match the parameter requirements of the
endpoint. A user must provide one of calendar or emails

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

This commit adds an optional keyword argument `calendar` to the
Nylas::CalendarCollection's availability related methods. This is
parameter is accepted by the latest API, but was not previously included
in the method definitions.

The argument requirements match the parameter requirements of the
endpoint. A user must provide on of `calendar` or `emails`
@mrashed-dev mrashed-dev self-requested a review March 18, 2022 16:10
Copy link
Contributor

@mrashed-dev mrashed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thanks for the well rounded PR, love the inclusion of calendar/email validation and the test case 🚀 Just going to push a change to fix the failing rubocop styling check

@mrashed-dev mrashed-dev merged commit c98f9fa into nylas:main Mar 18, 2022
@mrashed-dev mrashed-dev mentioned this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants