Add timezone fields to the When class #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for us to validate that the strings passed in by the user are IANA formatted
To match ruby standards and because we should return a value
mrashed-dev
requested review from
a team,
quzhi1 and
dominicj-nylas
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 97.56% 97.58% +0.01%
==========================================
Files 124 125 +1
Lines 4396 4429 +33
==========================================
+ Hits 4289 4322 +33
Misses 107 107
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Failing CI |
|
@quzhi1 Thanks! Fixed CI pulling an older version of Rails 5, now CI runs. |
quzhi1
approved these changes
Sep 26, 2022
mrashed-dev
deleted the
CUST-1159-ruby-sdk-start-end-timezone-missing-from-when-class
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
timezone,start_timezoneandend_timezonefields. This SDK also now uses tzinfo as a dev dependency to validate the strings set by the user are indeed IANA database names.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.