Adds visibility attribute in Event.rb #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrashed-dev
reviewed
Oct 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #385 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 125 125
Lines 4429 4431 +2
=======================================
+ Hits 4322 4324 +2
Misses 107 107
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mrashed-dev
suggested changes
Oct 11, 2022
There was a problem hiding this comment.
@brunossilveira Thank you so much for opening this PR! It looks good mostly, just made a comment about the readability of the variable. Once amended I'll approve and merge. 🚀
Co-authored-by: Mostafa Rashed <17770919+mrashed-dev@users.noreply.github.com>
|
Done! |
mrashed-dev
approved these changes
Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
visibilityattribute to theEventclass.I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.