Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and add missing webhook triggers #403

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Conversation

mrashed-dev
Copy link
Contributor

Description

This PR fixes the MESSAGE_LINK_CLICKED value, and adds missing Job status webhook triggers.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #403 (e1a9b02) into main (4d834e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         128      128           
  Lines        4712     4714    +2     
=======================================
+ Hits         4610     4612    +2     
  Misses        102      102           
Impacted Files Coverage Δ
lib/nylas/webhook.rb 96.87% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mrashed-dev mrashed-dev merged commit 5a0e49d into main Feb 6, 2023
@mrashed-dev mrashed-dev deleted the fix-webhook-triggers branch February 6, 2023 23:49
@mrashed-dev mrashed-dev mentioned this pull request Mar 13, 2023
mrashed-dev added a commit that referenced this pull request Mar 14, 2023
New Nylas Ruby SDK v5.16.0 release brings the following additions:
* Add missing `provider_id` attribute to `Label` (#404)
* Add missing job status webhook triggers (#403)
* Fix `MESSAGE_LINK_CLICKED` trigger (#403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants