Some of the test names were a little confusing.

[apokalyptik]

You have protocol validation tests under the lockd client heading in tests which made me thing that you were testing features of the client.

eg "serializes operations on a single client" made me think you were trying to do some magic to make multiple instances share the same connection. And "forbids a client to get a lock another client already holds" made me think you were keeping an internal list of locks and having multiple clients check to avoid sending a command to the server.

Not wrong, but confusing as I searched for that in the code to verify what was going on :)

[nylen]

Ah, right. I'll work out how to organize the tests better.

The one about serializing is a feature of the client library: since commands may return multiple lines, it performs server requests in series. See relevant code and test lines, and I've added some documentation. How can I word this better / make it more clear what's being tested?

[apokalyptik]

How about something like "Concurrent requests are properly serialized inside a client" ?

[nylen]

Done. I'll leave this open until there are more tests and I've organized them better.

[nylen]

The tests are better organized now, but that same test (serializes concurrent requests from a single client) still sticks out as being misplaced.

It's an important test, though, and this is definitely the easiest place to put it since there will be a real lockd server running at that point. So, I'm inclined to leave it alone for now and leave this issue open.