-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'statusBarMode' to drive whether the status bar is hidden or not. #336
base: develop
Are you sure you want to change the base?
Conversation
… example to demonstrate the feature.
Co-authored-by: Zev Eisenberg <zev.eisenberg@nytimes.com>
@ZevEisenberg, if you like my notch code, this is ready to merge. |
…operly, stop setting the global BUNDLE_PATH
@@ -11,6 +11,8 @@ fi | |||
|
|||
cd "$(dirname "$0")/../Examples" | |||
|
|||
bundle config set path 'vendor/bundle' | |||
# uncomment the following if you get errors about not having access to the system's install | |||
# bundle config --local path 'vendor/bundle' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually pretty rare to mention this stuff in a script like this. If we want to guide people on their ruby setup, maybe we should do it in the readme instead, under a "Contributing" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm happy to delete it. it's probably wrong-advice anyway.
@@ -41,6 +41,12 @@ extern NSString * const NYTPhotosViewControllerDidDismissNotification; | |||
|
|||
@interface NYTPhotosViewController : UIViewController | |||
|
|||
typedef NS_ENUM(NSUInteger, NYTPhotoViewerStatusBarMode) { | |||
NYTPhotoViewerStatusBarModeDynamic, /* hide statusbar when view.safeArea.top == 0 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A doc comment instead of a regular comment would make this show up in the inline doc viewer. Probably best to add comments for all the cases.
contents of #221, plus a couple tweaks.
cc @sergiog90
Original PR contents: