Separate Kubernetes Secret object type #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| data["secrets"] = secrets |
There was a problem hiding this comment.
TBD: eliminate possibility of using encoded secrets values in .kube.yml, do not set data["secrets"].
contains private keys and github token
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate secrets values in your
.drone.ymlapart from regular variables passed to the k8s pod spec.Setting
verbose: truein.drone.ymlwill not dump/show secret values.They can still be shown when
verbose: trueand thesecrets.*template values are accessed in.kube.yml, although this should not be done.Perhaps in the future, secret values are extracted from the
dataobject, and are executed into the secrets template independently ofdataobject's values.