Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swapped if/else branches #38

Merged
merged 5 commits into from
Mar 24, 2016
Merged

Swapped if/else branches #38

merged 5 commits into from
Mar 24, 2016

Conversation

darrenmcc
Copy link
Contributor

Logic was backwards. Swapped branches so a non-empty location string gets parsed rather than DefaultLocation in that case.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.064% when pulling eb1cab7 on darrenmcc:swap-mysql-location into 5e9125b on NYTimes:master.

@jprobinson jprobinson merged commit 6eb2798 into nytimes:master Mar 24, 2016
@jprobinson
Copy link
Contributor

💥 thankyousir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darrenmcc @coveralls @jprobinson