remove filter by slug key #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@penina-nyt this looks great! Sorry about the big delay on a review here. Happy to merge as soon as tests pass, and happy to help with those if that would be helpful! |
…-the-same-title-as-parents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We had a bug where any document that shared a name with the parent folder was not visible in the document tree. We were filtering by the slug, which was the same as the parent. We removed this filter, and the child items are now visible.
Related Issue
#253
Motivation and Context
First reported by @jessie-wu-nyt in #library-contributors slack channel
Checklist
npm run lintand updated code style accordinglynpm run testpasses