huge refactor #115
Merged
huge refactor #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes while the block is blocked
|
Oh, and we should probably tag the current release... |
|
made tag |
|
well, it runs |
| if _, ok := s.blocks[c]; ok { | ||
| err := s.DeleteBlock(c) | ||
| if err != nil { | ||
| fmt.Println(err) |
|
🍏 📗 💚 |
This was referenced Nov 10, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge refactor that migrates the visual graph from SVG to canvas. This provides monumental benefits to performance and scalability. The canvas implementation consists of several buffers that store an image of various elements (nodes, edges) that are all composed together to build the final visual representation of the graph. The canvas implementation can handle thousands of nodes per group -- and probably can be optimized further.
The data structures that govern how the model interacts with the views is now written with a Flux-like architecture in mind.
This PR introduces some regressions (in order of priority):
gandu)