Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for single-task configurator #1143

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Bugfix for single-task configurator #1143

merged 3 commits into from
Oct 12, 2020

Conversation

zphang
Copy link
Collaborator

@zphang zphang commented Oct 11, 2020 •
edited
Loading

  • Remove train_val cache
  • Remove type=bool

@codecov
Copy link

codecov bot commented Oct 11, 2020 •
edited
Loading

Codecov Report

Merging #1143 into master will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   56.87%   56.85%   -0.03%     
==========================================
  Files         132      132              
  Lines        9652     9652              
==========================================
- Hits         5490     5488       -2     
- Misses       4162     4164       +2
Impacted Files Coverage Δ
jiant/proj/main/scripts/configurator.py 59.13% <75.00%> (ø)
jiant/utils/zconf/core.py 72.34% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14fac1c...8d17ad9. Read the comment docs.

@zphang zphang changed the title Remove train_val cache Bugfix for single-task configurator Oct 12, 2020
@jeswan jeswan merged commit aa4d111 into nyu-mll:master Oct 12, 2020
leo-liuzy pushed a commit to leo-liuzy/dynamic_jiant that referenced this pull request Nov 11, 2020
@zphang
Bugfix for single-task configurator (nyu-mll#1143)
e0a6ce4 
* Remove train_val cache

* Remove type=bool

* val_labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeswan jeswan jeswan approved these changes

@HaokunLiu HaokunLiu Awaiting requested review from HaokunLiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zphang @jeswan