-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual regression test #15
Conversation
aabd591
to
e4b7311
Compare
CI not working because of my wrong configuration🤔 I'll dig into it later. |
e4b7311
to
112984c
Compare
Regression tests are passing in GitHub Actions👏 |
Now it's ready for review! I'd like feedback especially on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does test/README.md make enough sense to you?
That is pretty clear to me :)
The existing test in t/ can be migrated to Jest snapshot tests in test. Do we wanna do that?
That helps a lot! Let's unify the language into JS for doing misc tasks in this repo.
f23848f
to
26d36e9
Compare
26d36e9
to
b5097e3
Compare
b5097e3
to
d67446a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging this PR will close #4
Steps for running integration test:
yarn install
to install dependenciesyarn test
to run testsYou can see the basic idea of the visual regression tests in this article.
Those tests will also run in GitHub Actions.
Future work: