Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression test #15

Merged
merged 18 commits into from
Dec 27, 2019
Merged

Visual regression test #15

merged 18 commits into from
Dec 27, 2019

Conversation

zeptometer
Copy link
Collaborator

Merging this PR will close #4

Steps for running integration test:

  1. Install SATySFi, Yarn, and GraphicsMagick
  2. Run yarn install to install dependencies
  3. Run yarn test to run tests

You can see the basic idea of the visual regression tests in this article.
Those tests will also run in GitHub Actions.

Future work:

@zeptometer zeptometer force-pushed the visual-regression-test branch 5 times, most recently from aabd591 to e4b7311 Compare December 15, 2019 02:08
@zeptometer
Copy link
Collaborator Author

CI not working because of my wrong configuration🤔 I'll dig into it later.

@zeptometer
Copy link
Collaborator Author

Regression tests are passing in GitHub Actions👏

@zeptometer
Copy link
Collaborator Author

Now it's ready for review! I'd like feedback especially on

  • Does __test__/README.md make enough sense to you?
  • The existing test in t/ can be migrated to Jest snapshot tests in __test__. Do we wanna do that?

@zeptometer zeptometer self-assigned this Dec 26, 2019
Copy link
Owner

@nyuichi nyuichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does test/README.md make enough sense to you?

That is pretty clear to me :)

The existing test in t/ can be migrated to Jest snapshot tests in test. Do we wanna do that?

That helps a lot! Let's unify the language into JS for doing misc tasks in this repo.

__test__/render.test.js Outdated Show resolved Hide resolved
@zeptometer zeptometer force-pushed the visual-regression-test branch 2 times, most recently from f23848f to 26d36e9 Compare December 27, 2019 03:18
Copy link
Owner

@nyuichi nyuichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeptometer zeptometer merged commit 678dc72 into master Dec 27, 2019
@nyuichi nyuichi mentioned this pull request Jan 14, 2020
@nyuichi nyuichi deleted the visual-regression-test branch February 9, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visual regression tests for typesetting libraries
2 participants