Skip to content
This repository has been archived by the owner on Nov 16, 2018. It is now read-only.

getImageURIString skips images that have query string parameters #32

Closed
sripathikrishnan opened this issue Aug 21, 2011 · 0 comments
Closed

getImageURIString skips images that have query string parameters #32

sripathikrishnan opened this issue Aug 21, 2011 · 0 comments

Comments

@sripathikrishnan
Copy link
Contributor

Some background images have query parameters in them, like this -

background-image : url('/path/to/image.png?width=64&height=64')

In such cases, the method getImageURIString(..) computes the file extension as png?width=64&height=64, and goes on to assume the URL is NOT an image.
sripathikrishnan added a commit to sripathikrishnan/cssembed that referenced this issue Aug 21, 2011
@sripathikrishnan
Issue nzakas#32 : Fixes getImageURIString to handle images with query…
493501d 
… parameters
nzakas added a commit that referenced this issue Aug 21, 2011
@nzakas
Merge pull request #33 from sripathikrishnan/master
6111b05 
Issue #32 : Fixes getImageURIString to handle images with query parameters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sripathikrishnan