Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#157693752 Fix inconsistent imnplementations #94

Merged
merged 1 commit into from
May 18, 2018

Conversation

nzediegwu1
Copy link
Owner

What does this PR do?

Fix inconsistent imnplementations in client app

Description of Task to be completed?

  1. Conditionally render events that were rejected using red color with a (rejected) text appended
  2. Conditionally render center availability on red color when closed
  3. In centerList page, conditionally render closed centers on red
  4. Conditionally render only events whose centers are open in eventList page
  5. Conditionally render centre text in red color followed by (closed), for events whose centre are closed
  6. In centerList component, conditionally render centres in red colour with a (closed) text appended, when closed

How should this be manually tested?

  1. On two terminal windows, run npm run start:dev and npm run client
  2. On browser, login to the app and navigate to the various pages affected to view and test fixes

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories? (If applicable)

#157693752

Screenshots (If applicable)

N/A

1. Conditionally render events that were rejected on red color with a (rejected) text appended
2. Conditionally render center availability on red color when closed
3. In centerList page, conditionally render closed centers on red
[Finishes #157693752]
@nzediegwu1 nzediegwu1 merged commit 45651c2 into develop May 18, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 21.73% when pulling bc9ca56 on fx/inconsistent-implementations-157693752 into c9ac484 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants