Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#157219929 Refactor backend source code #99

Merged
merged 2 commits into from
May 30, 2018
Merged

Conversation

nzediegwu1
Copy link
Owner

What does this PR do?

Refactor backend source code

Description of Task to be completed?

  1. Exclude server/migrations in code climate config
  2. Modify logout function to better reusability in client/service.js
  3. Define updateAndEmail, create and modifyEvent functions in server/service.js for better reusability
  4. Validate event approval route

How should this be manually tested?

  1. On terminal, run command: npm run start:dev
  2. On Postman, test routes affected to confirm that they still work as expected

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories? (If applicable)

[#157219929]

Screenshots (If applicable)

N/A

Anaeze Nsoffor added 2 commits May 30, 2018 16:26
1. Exclude server/migrations in code climate config
2. Modify logout function to better reusability in client/service.js
3. Define updateAndEmail, create and modifyEvent functions in server/service.js for better reusability
4. Validate event approval route

[Finishes #157219929]
@nzediegwu1 nzediegwu1 merged commit 4ce7aaa into develop May 30, 2018
@coveralls
Copy link

coveralls commented May 30, 2018

Coverage Status

Coverage decreased (-0.2%) to 26.018% when pulling 61bdc3a on fx/refactor-server-code into 82a44e1 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants