Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of travisci #5

Merged
merged 5 commits into from
Feb 14, 2018
Merged

implementation of travisci #5

merged 5 commits into from
Feb 14, 2018

Conversation

foutoucour
Copy link
Collaborator

No description provided.

@foutoucour
Copy link
Collaborator Author

Faut rajouter travis maintenant :)

@foutoucour
Copy link
Collaborator Author

Et faire la PR de tes tests :)

@nzin
Copy link
Owner

nzin commented Jan 9, 2018

ca m'a l'air bon. tu veux que je merge?

@foutoucour
Copy link
Collaborator Author

@nzin il faut rajouter l'integration travis. Meme s'il y a pas de tests encore :)

@foutoucour
Copy link
Collaborator Author

Je crois que tu vas me detester avec la mise en place de golint :)

@nzin
Copy link
Owner

nzin commented Jan 10, 2018

Salut,

le truc c'est que j'utilise systématiquement Visual Code Studio, et il me lint automatiquement.
Si tu mets golint: soit il fait exactement le boulot, soit ca va rentrer en conflit.

@nzin
Copy link
Owner

nzin commented Jan 10, 2018

bref, je ne vois pas trop l'intérêt

@foutoucour
Copy link
Collaborator Author

je vois. Mais je suis surpris parce golint trouve beaucoup de points a revoir sur le code. Tu as quoi comme setup dans VCS?

@nzin
Copy link
Owner

nzin commented Jan 10, 2018 via email

@foutoucour
Copy link
Collaborator Author

je merge? :)

@nzin
Copy link
Owner

nzin commented Feb 14, 2018

est ce qu'on pourrait closer ce PR et en faire un autre? je vois des redondance avec ce qui a déjà été fait.
genre: docker-compose run --rm app go test ./... ou bien le Dockerfile

Copy link
Owner

@nzin nzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a Dockerfile, this PR isn't redundant?

@nzin
Copy link
Owner

nzin commented Feb 14, 2018

je me suis trompé, je croyais qu'on était sur dctycoon...

Copy link
Owner

@nzin nzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzin nzin merged commit c6d6aa8 into master Feb 14, 2018
@nzin nzin deleted the travisci branch February 14, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants