-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isSuccess always returns true #819
Comments
IRI: @MartinMinkov |
I have been failing to reproduce this issue. I have tried sending invalid transactions on purpose (like invalid nonce, invalid fee amount, invalid verification key), and |
@MartinMinkov with which graphql endpoint have you tested? It may work on some but not all. It didn't seem to work on the Mina node that's running inside the snarkyjs integration test for @Trivo25 |
So far, just |
fix
isSuccess
to be true only and only if the tx was successful, currently its always trueseems like we arent parsing the graphql response correctly - mid-size annoyance if you are running a live script
The text was updated successfully, but these errors were encountered: