Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isSuccess always returns true #819

Closed
Trivo25 opened this issue Mar 29, 2023 · 4 comments · Fixed by #826
Closed

isSuccess always returns true #819

Trivo25 opened this issue Mar 29, 2023 · 4 comments · Fixed by #826
Assignees
Labels
bug Something isn't working product-eng For tracking our team's issues

Comments

@Trivo25
Copy link
Member

Trivo25 commented Mar 29, 2023

fix isSuccess to be true only and only if the tx was successful, currently its always true

seems like we arent parsing the graphql response correctly - mid-size annoyance if you are running a live script

@nicc
Copy link
Collaborator

nicc commented Apr 12, 2023

IRI: @MartinMinkov

@MartinMinkov
Copy link
Contributor

I have been failing to reproduce this issue. I have tried sending invalid transactions on purpose (like invalid nonce, invalid fee amount, invalid verification key), and isSuccess is correctly returning false. What counts as "always" returning true? 🤔

@mitschabaude
Copy link
Contributor

@MartinMinkov with which graphql endpoint have you tested? It may work on some but not all. It didn't seem to work on the Mina node that's running inside the snarkyjs integration test for @Trivo25

@MartinMinkov
Copy link
Contributor

So far, just berkeley.minaexplorers GraphQL endpoint. I will take a closer look at the integration tests and experiment with different URLs. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product-eng For tracking our team's issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants