Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swallowed errors during comms with Archive-Node-API #841

Closed
shimkiv opened this issue Apr 10, 2023 · 0 comments · Fixed by #919
Closed

Swallowed errors during comms with Archive-Node-API #841

shimkiv opened this issue Apr 10, 2023 · 0 comments · Fixed by #919
Assignees
Labels
bug Something isn't working error-messages Issues about making error messages better product-eng For tracking our team's issues

Comments

@shimkiv
Copy link
Member

shimkiv commented Apr 10, 2023

During the events and actions fetching we rely on error variable to be defined by problematic response when in fact errors an array of errors is usually returned by GraphQL, example:

{
  "errors": [
    {
        "locations": [
            {
                "column": 3,
                "line": 13
            }
        ],
        "message": "Field \"actionState\" of type \"ActionStates!\" must have a selection of subfields. Did you mean \"actionState { ... }\"?"
    }
  ]
}

Thus, check like this or this won't result in error being thrown.
But then, the call execution will be interrupted by this or this lines when we're going to refer to undefined.

@shimkiv shimkiv added the bug Something isn't working label Apr 10, 2023
@nicc nicc added error-messages Issues about making error messages better product-eng For tracking our team's issues labels May 8, 2023
@MartinMinkov MartinMinkov linked a pull request May 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working error-messages Issues about making error messages better product-eng For tracking our team's issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants