Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeted utf8mb3 to utf8mb4 fix for query_doc_pairs.document_field #1017

Merged
merged 2 commits into from
May 15, 2024

Conversation

epugh
Copy link
Member

@epugh epugh commented May 12, 2024

Description

This just makes the minimal change to support emoji.

Motivation and Context

This is a targted fix for #1013 issue, that doesn't try to clean up the overall schema....

It is an alternative to #1016 which I am more nervous about rolling out!

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh epugh linked an issue May 12, 2024 that may be closed by this pull request
@epugh epugh requested a review from wrigleyDan May 12, 2024 14:46
@epugh epugh merged commit eb105a7 into main May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change charset in database schema to utf8mb4
1 participant