Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a wonderful easter egg, but we are being ruthless and winnowing code #123

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

epugh
Copy link
Member

@epugh epugh commented Apr 25, 2020

Description

Wow, who knew that this was here?

curate

Motivation and Context

This feature is something we want, the mythical "I am a content person and I'm going to rate some search results". I had no idea, in six years of using Quepid that this was even here.

However, we are being ruthless on pruning code, and narrowing down the Angular1 foot print. In the future though, we'd love to have this!

How Has This Been Tested?

Manually and unit tests.

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • Removing feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • I have removed tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh merged commit ab11a3b into master Apr 27, 2020
@epugh epugh deleted the remove_curate_query_concept branch December 6, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant