Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coffee script for performance and tech debt reasons #283

Merged
merged 5 commits into from
Mar 9, 2021

Conversation

epugh
Copy link
Member

@epugh epugh commented Mar 9, 2021

Description

Converted our two .coffee scripts to .js

Motivation and Context

The "derailed" tool reported that coffee-script was .3 MB of memory, and while I thought we had tons of .coffee files, it turns out we only had two! Swapping from JS to coffeescript was always a werid cognitive swap as well.

Big thanks to the Decaffeinate project for the online REPL to convert the two files, it worked PERFECTLY. I might have left those two .coffee files thinking the conversion would be a real pain for a long time without the tool!

How Has This Been Tested?

manually.

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

epugh@opensourceconnections.com added 2 commits March 9, 2021 07:07
we only had two uses.  Lets get rid of coffee script, it's one more cognitive load thing to learn to use in Quepid.
@epugh epugh temporarily deployed to quepid-pr-283 March 9, 2021 12:48 Inactive
@epugh epugh temporarily deployed to quepid-pr-283 March 9, 2021 15:36 Inactive
@epugh epugh merged commit dbe22fd into master Mar 9, 2021
@epugh epugh deleted the remove_coffee_script_for_perf branch March 11, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant