Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query soft delete #299

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Remove query soft delete #299

merged 4 commits into from
Mar 26, 2021

Conversation

epugh
Copy link
Member

@epugh epugh commented Mar 22, 2021

die soft delete die!

Description

Removes the soft delete capablity.

One thing is that we will now change how snapshots work.... If you delete a query, it will also be deleted out any snapshots!

Motivation and Context

#298 identified that we have some issues.

How Has This Been Tested?

Unit tests, and restoring prod to dev to check the migration.

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh linked an issue Mar 22, 2021 that may be closed by this pull request
@epugh epugh temporarily deployed to quepid-pr-299 March 22, 2021 17:16 Inactive
@epugh epugh temporarily deployed to quepid-pr-299 March 22, 2021 17:25 Inactive
@epugh epugh temporarily deployed to quepid-pr-299 March 26, 2021 19:25 Inactive
@epugh epugh merged commit 4737ba2 into master Mar 26, 2021
@epugh epugh deleted the remove_query_soft_delete branch January 8, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soft-deletion feature leads to orphan snapshots
1 participant