Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/media embeds #62

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Feature/media embeds #62

merged 4 commits into from
Jan 15, 2020

Conversation

worleydl
Copy link
Contributor

Adds support for embedding media denoted by media: in the fieldSpec. Relies on o19s/splainer-search#78 to function.

Description

Added a new media section to the field listing that will embed any supported audio/image/video URLS.

Motivation and Context

Fixes Issue #56

How Has This Been Tested?

Tests have been added to the splainer code, the rendering was tested manually for an audio/image/video embed.

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh merged commit 72f381e into master Jan 15, 2020
epugh added a commit that referenced this pull request Jan 16, 2020
@epugh epugh deleted the feature/media-embeds branch December 6, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants