Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review defaults for scorers #97

Merged
merged 6 commits into from
Mar 16, 2020
Merged

Review defaults for scorers #97

merged 6 commits into from
Mar 16, 2020

Conversation

epugh
Copy link
Member

@epugh epugh commented Mar 14, 2020

Removing some code from scorers that isn't really used, and that is confusing.

Description

Remove the DEFAULTS concept, since we don't actually ahve a default anymore, cause we are introducing many scorers to Quepid. So the "default" can't just be assumed.
Also, the frontend custom scorer and default scorer screens use their own set of default scorer code, it doesn't come form the back end.

Motivation and Context

Fixes #58 at least partly.

How Has This Been Tested?

unit tests and manually

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    Need to run a migration.

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epugh epugh requested a review from worleydl March 14, 2020 13:34
@epugh
Copy link
Member Author

epugh commented Mar 14, 2020

Assuming this builds succesfully, this is ready for review and commit @worleydl

@worleydl worleydl merged commit 1e62409 into master Mar 16, 2020
@worleydl worleydl deleted the review_defaults_for_scorers branch March 16, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate scorers in schema
2 participants